Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Grouping in warp #498

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Grouping in warp #498

wants to merge 3 commits into from

Conversation

jotsif
Copy link

@jotsif jotsif commented Nov 13, 2019

Hi!

I am working on a use case right now where a lot of items are short-lived, i.e. only available for a short period of time. In this case WARP-loss is not optimal since it can sample negative items that were not available when the positive item was relevant.

The following PR modifies the WARP loss by sampling only negative items from a predefined group (it could be month for example). I have seen that this improves the performance substantially in my case. When AUC is measured correctly (i.e. intra-group) it generally is increased by a number of percentage points.

I have added a few tests, and made some modifications to the documentation, but did not spend too much time on these things since I wanted to assess the possibility of including a change like this into the main code before working more on all these bells and whistles.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant